extract bindings #128
Open
extract bindings #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note that for now I solved this with webpack plugin which replaces node-gyp-build with a dummy import file but it would be much more convenient if it is possible to use simple externals as in the example above. import path from 'node:path';
import { Resolver } from 'webpack';
export const AddonPlugin = {
apply(resolver: Resolver) {
resolver.getHook('before-resolve')
.tapAsync('AddonPlugin', (request, _resolveContext, callback) => {
if (request.path &&
request.path?.match(/\@serialport\/bindings-cpp/) &&
request.request?.match(/node-gyp-build/)) {
request.request = path.join(__dirname, './serialport.js');
}
callback();
});
}
};export default () => require('./addons/serialport.node'); |
|
This seems fine, however I can't get the actions to run as it's been a long time. Would you be able to do an empty commit and push to your branch to trigger it again? eg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have a use case where size of an application is important, I'd like to webpack as much as possible. The problematic part is related *.node files, I found a potential solution, example with sqlite:
I can replace sqlite3-binding.js [1] with *.node, then I copy node_sqlite3.node to the main application folder. I'd like to try something similar with the serialport. However, it is slightly more complicated since serialport doesn't have single import file. This PR is an attempt to fix the problem.
[1] https://github.com/TryGhost/node-sqlite3/blob/master/lib/sqlite3-binding.js